Merge pull request #224 from nextcloud/techdebt/noid/validate-infoxml-with-workflow

Validate the info.xml with a github workflow

.github/workflows/lint.yml

@@ -43,3 +43,16 @@ jobs:
         run: composer i
       - name: Run coding standards check
         run: composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )
+
+  xml-linters:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@master
+      - name: Download schema
+        run: wget https://apps.nextcloud.com/schema/apps/info.xsd
+      - name: Lint info.xml
+        uses: ChristophWurst/xmllint-action@v1
+        with:
+          xml-file: ./appinfo/info.xml
+          xml-schema-file: ./info.xsd

.travis.yml

@@ -57,12 +57,6 @@ install:
   - . ${BUILD_APP_MODULE_DIR}/tests/scripts/core-setup.sh
 
 script:
-  # Check info.xml schema validity
-  - . ${BUILD_APP_MODULE_DIR}/tests/scripts/lint-appinfo.sh
-
-  # Check PHP syntax errors
-  - . ${BUILD_APP_MODULE_DIR}/tests/scripts/lint-php.sh
-
   # Run app code checker but do not fail, as we have to use private API for now
   - . ${BUILD_APP_MODULE_DIR}/tests/scripts/app-check-code.sh || true
 

tests/scripts/lint-appinfo.sh

@@ -1,13 +0,0 @@
-#!/usr/bin/env bash
-
-echo "travis_fold:start:lint.appinfo"
-
-set -e
-
-cd ${BUILD_APP_MODULE_DIR}
-
-wget -nv https://apps.nextcloud.com/schema/apps/info.xsd
-xmllint appinfo/info.xml --schema info.xsd --noout
-rm info.xsd
-
-echo "travis_fold:end:lint.appinfo"

tests/scripts/lint-php.sh

@@ -1,11 +0,0 @@
-#!/usr/bin/env bash
-
-echo "travis_fold:start:lint.php"
-
-set -e
-
-cd ${BUILD_APP_MODULE_DIR}
-
-find . -name '*.php' -type f -not -path './vendor/*' -print0 | xargs --no-run-if-empty -0 -n1 -P8 php -l -d display_errors -d display_startup_errors 1>/dev/null
-
-echo "travis_fold:end:lint.php"