From 45efd7f3463f6518a9172c9a8d1f2a52456d0872 Mon Sep 17 00:00:00 2001
From: Pellaeon Lin <nfsmwlin@gmail.com>
Date: Sat, 24 Feb 2018 22:39:32 +0800
Subject: [PATCH] Fix# should fix #123

---
 service/registrationservice.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/service/registrationservice.php b/service/registrationservice.php
index a77efa3..bba2e19 100644
--- a/service/registrationservice.php
+++ b/service/registrationservice.php
@@ -122,6 +122,7 @@ class RegistrationService {
 		$this->registrationMapper->update($registration);
 	}
 	/**
+	 * Create registration request, used by both the API and form
 	 * @param string $email
 	 * @param string $username
 	 * @param string $password
@@ -138,7 +139,8 @@ class RegistrationService {
 			$registration->setPassword($password);
 		}
 		$this->registrationMapper->generateNewToken($registration);
-		$this->registrationMapper->generateClientSecret($registration);
+		if ( $password !== '' && $username !== '' )
+			$this->registrationMapper->generateClientSecret($registration);
 		$this->registrationMapper->insert($registration);
 		return $registration;
 	}
@@ -301,6 +303,9 @@ class RegistrationService {
 		}
 
 		// Delete pending registration if no client secret is stored
+		// with client secret implies registered via API
+		// without client secret implies registered via form
+		// if registered via API, the registration request will be deleted in apicontroller::status
 		if($registration->getClientSecret() === null) {
 			$res = $this->registrationMapper->delete($registration);
 			if ($res === false) {