From ab641685ed46dcc4d646a579dafbb1b28f5b1716 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Tue, 17 Nov 2020 19:57:14 +0100 Subject: [PATCH] Split the flows for less code intendation Signed-off-by: Joas Schilling --- lib/Controller/RegisterController.php | 26 +++++++++++++------------- lib/Service/RegistrationService.php | 2 +- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/Controller/RegisterController.php b/lib/Controller/RegisterController.php index b325a42..3f83d4a 100644 --- a/lib/Controller/RegisterController.php +++ b/lib/Controller/RegisterController.php @@ -137,20 +137,20 @@ class RegisterController extends Controller { ] ) ); - } else { - try { - $this->mailService->sendTokenByMail($registration); - } catch (RegistrationException $e) { - return $this->showEmailForm($email, $e->getMessage()); - } - - return new RedirectResponse( - $this->urlGenerator->linkToRoute( - 'registration.register.showVerificationForm', - ['secret' => $registration->getClientSecret()] - ) - ); } + + try { + $this->mailService->sendTokenByMail($registration); + } catch (RegistrationException $e) { + return $this->showEmailForm($email, $e->getMessage()); + } + + return new RedirectResponse( + $this->urlGenerator->linkToRoute( + 'registration.register.showVerificationForm', + ['secret' => $registration->getClientSecret()] + ) + ); } /** diff --git a/lib/Service/RegistrationService.php b/lib/Service/RegistrationService.php index bc71ac4..65bde42 100644 --- a/lib/Service/RegistrationService.php +++ b/lib/Service/RegistrationService.php @@ -142,7 +142,7 @@ class RegistrationService { $registration->setEmail($email); $registration->setUsername($username); $registration->setDisplayname($displayname); - if ($password !== "") { + if ($password !== '') { $password = $this->crypto->encrypt($password); $registration->setPassword($password); }